From dd591f1661f3d2f788922e23b45c4169434ada93 Mon Sep 17 00:00:00 2001 From: Shivam Mathur Date: Tue, 15 Jun 2021 23:56:55 +0530 Subject: [PATCH] Use shivammathur/extensions tap for rdkafka on macOS --- __tests__/extensions.test.ts | 3 ++- dist/index.js | 2 +- src/extensions.ts | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/__tests__/extensions.test.ts b/__tests__/extensions.test.ts index 5003173a..a6e9451b 100644 --- a/__tests__/extensions.test.ts +++ b/__tests__/extensions.test.ts @@ -160,7 +160,7 @@ describe('Extension tests', () => { it('checking addExtensionOnDarwin', async () => { let darwin: string = await extensions.addExtension( - 'amqp, apcu, Xdebug, pcov, grpc, igbinary, imagick, imap, memcache, memcached, msgpack, phalcon3, phalcon4, protobuf, psr, redis, swoole, sqlite, oci8, pdo_oci, :intl, ast-beta, grpc-1.2.3', + 'amqp, apcu, Xdebug, pcov, grpc, igbinary, imagick, imap, memcache, memcached, msgpack, phalcon3, phalcon4, protobuf, psr, rdkafka, redis, swoole, sqlite, oci8, pdo_oci, :intl, ast-beta, grpc-1.2.3', '7.2', 'darwin' ); @@ -179,6 +179,7 @@ describe('Extension tests', () => { expect(darwin).toContain('add_brew_extension phalcon4 extension'); expect(darwin).toContain('add_brew_extension protobuf extension'); expect(darwin).toContain('add_brew_extension psr extension'); + expect(darwin).toContain('add_brew_extension rdkafka extension'); expect(darwin).toContain('add_brew_extension redis extension'); expect(darwin).toContain('add_brew_extension swoole extension'); expect(darwin).toContain('add_extension sqlite3'); diff --git a/dist/index.js b/dist/index.js index 638583ac..cd29be61 100644 --- a/dist/index.js +++ b/dist/index.js @@ -229,7 +229,7 @@ async function addExtensionDarwin(extension_csv, version) { case /(5\.[3-6]|7\.0)pcov/.test(version_extension): add_script += await utils.getUnsupportedLog('pcov', version, 'darwin'); return; - case /(?