actions/setup-php
1
0
Fork 0
mirror of https://github.com/shivammathur/setup-php.git synced 2026-09-21 02:10:54 +07:00
Code Issues Packages Projects Releases Wiki Activity

Limit Windows extension recovery overhead to DLL replacements

Browse Source
This commit is contained in:
Shivam Mathur
2026-09-19 19:46:03 +05:30
parent 84a5f1c061
commit d76a76348c
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/scripts/extensions/add_extensions.ps1
+22 -9
View File
@@ -105,16 +105,27 @@ Function Add-Extension {
$extension_version = '' $extension_version = ''
) )
$extension_backup = '' $extension_backup = ''
$startup_errors = Get-PhpIniKey -Key display_startup_errors -Path "$php_dir\php.ini" $restore_startup_errors = $false
try { try {
# PhpManager parses php -m while DLLs are temporarily moved or replaced.
Set-PhpIniKey -Key display_startup_errors -Value Off -Path "$php_dir\php.ini"
$deps_dir = "$ext_dir\$extension-vc$($installed.VCVersion)-$arch" $deps_dir = "$ext_dir\$extension-vc$($installed.VCVersion)-$arch"
New-Item $deps_dir -Type Directory -Force > $null 2>&1 New-Item $deps_dir -Type Directory -Force > $null 2>&1
$extension_info = Get-PhpExtension -Path $php_dir | Where-Object { $_.Name -eq $extension -or $_.Handle -eq $extension } $cached = $extension_version -ne '' -and (Test-Path "$ext_dir\$extension-$extension_version")
if($extension_version -ne '' -and (Test-Path "$ext_dir\$extension-$extension_version")) { $extension_info = $null
if(-not $cached) {
$extension_info = Get-PhpExtension -Path $php_dir | Where-Object { $_.Name -eq $extension -or $_.Handle -eq $extension }
}
# Only suppress startup errors while probing a cached DLL or replacing an installed DLL.
if($cached -or ($extension_version -ne '' -and $extension_info.Version -ne $extension_version -and (Test-Path "$ext_dir\php_$extension.dll"))) {
$startup_errors = Get-PhpIniKey -Key display_startup_errors -Path "$php_dir\php.ini"
if($startup_errors -notmatch '^(0|off|false|no)$') {
$restore_startup_errors = $true
Set-PhpIniKey -Key display_startup_errors -Value Off -Path "$php_dir\php.ini"
}
}
if($cached) {
# Preserve the active DLL before probing a cache entry for another PHP build. # Preserve the active DLL before probing a cache entry for another PHP build.
if(Test-Path "$ext_dir\php_$extension.dll") { if(Test-Path "$ext_dir\php_$extension.dll") {
$extension_info = Get-PhpExtension -Path "$ext_dir\php_$extension.dll"
$backup_name = if($extension_info.Version) { "$extension-$($extension_info.Version)" } else { "$extension.bak" } $backup_name = if($extension_info.Version) { "$extension-$($extension_info.Version)" } else { "$extension.bak" }
Copy-Item "$ext_dir\php_$extension.dll" "$ext_dir\$backup_name" -Force -ErrorAction Stop Copy-Item "$ext_dir\php_$extension.dll" "$ext_dir\$backup_name" -Force -ErrorAction Stop
$extension_backup = "$ext_dir\$backup_name" $extension_backup = "$ext_dir\$backup_name"
@@ -185,10 +196,12 @@ Function Add-Extension {
} }
Add-Log $cross $extension "Could not install $extension on PHP $( $installed.FullVersion )" Add-Log $cross $extension "Could not install $extension on PHP $( $installed.FullVersion )"
} finally { } finally {
if($null -eq $startup_errors) { if($restore_startup_errors) {
Set-PhpIniKey -Key display_startup_errors -Delete -Path "$php_dir\php.ini" if($null -eq $startup_errors) {
} else { Set-PhpIniKey -Key display_startup_errors -Delete -Path "$php_dir\php.ini"
Set-PhpIniKey -Key display_startup_errors -Value $startup_errors -Path "$php_dir\php.ini" } else {
Set-PhpIniKey -Key display_startup_errors -Value $startup_errors -Path "$php_dir\php.ini"
}
} }
} }
} }