actions/setup-php
1
0
Fork 0
mirror of https://github.com/shivammathur/setup-php.git synced 2026-01-23 00:58:57 +07:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to use ES2024+ features for Node 24

Browse Source 
Use Set for O(1) redirect status code lookup in fetch.ts

Use at(-1) and Object.hasOwn() in tools.ts

Use for...of with entries() in utils.ts
This commit is contained in:
Shivam Mathur
2026-01-20 06:46:28 +05:30
parent f0e37f9e90
commit 871ff01b2b
4 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dist/index.js vendored
View File

File diff suppressed because one or more lines are too long

10
src/fetch.ts
View File

@@ -1,3 +1,8 @@
/**
* Redirect status codes set for O(1) lookup
*/
const REDIRECT_CODES = new Set([301, 302, 303, 307, 308]);
/** /**
* Function to fetch a URL using native fetch API (Node 24+) * Function to fetch a URL using native fetch API (Node 24+)
* *
@@ -26,10 +31,7 @@ export async function fetch(
if (response.ok) { if (response.ok) {
const data = await response.text(); const data = await response.text();
return {data}; return {data};
} else if ( } else if (REDIRECT_CODES.has(response.status) && redirect_count <= 0) {
[301, 302, 303, 307, 308].includes(response.status) &&
redirect_count <= 0
) {
return {error: `${response.status}: Redirect error`}; return {error: `${response.status}: Redirect error`};
} else { } else {
return {error: `${response.status}: ${response.statusText}`}; return {error: `${response.status}: ${response.statusText}`};

4
src/tools.ts
View File

@@ -140,7 +140,7 @@ export async function filterList(tools_list: string[]): Promise<string[]> {
case matches[0] == undefined: case matches[0] == undefined:
break; break;
default: default:
composer = matches[matches.length - 1].replace(/v(\d\S*)/, '$1'); composer = matches.at(-1)!.replace(/v(\d\S*)/, '$1');
break; break;
} }
tools_list.unshift(composer); tools_list.unshift(composer);
@@ -488,7 +488,7 @@ export async function getData(
const tool = parts[0]; const tool = parts[0];
const version = parts[1]; const version = parts[1];
let data: RS; let data: RS;
if (Object.keys(json_objects).includes(tool)) { if (Object.hasOwn(json_objects, tool)) {
data = json_objects[tool]; data = json_objects[tool];
data['tool'] = tool; data['tool'] = tool;
} else { } else {

7
src/utils.ts
View File

@@ -97,9 +97,8 @@ export async function parseIniFile(ini_file: string): Promise<string> {
} }
/** /**
* Async foreach loop * Async foreach loop using modern for...of pattern
* *
* @author https://github.com/Atinux
* @param array * @param array
* @param callback * @param callback
*/ */
@@ -111,8 +110,8 @@ export async function asyncForEach(
array: Array<string> array: Array<string>
) => Promise<void> ) => Promise<void>
): Promise<void> { ): Promise<void> {
for (let index = 0; index < array.length; index++) { for (const [index, element] of array.entries()) {
await callback(array[index], index, array); await callback(element, index, array);
} }
} }