mirror of
https://github.com/shivammathur/setup-php.git
synced 2024-11-22 20:01:06 +07:00
Address review feedback
This commit is contained in:
parent
fd62612e9e
commit
3f466981fc
@ -59,15 +59,6 @@ export async function addExtensionDarwin(
|
|||||||
// the version may match that as well
|
// the version may match that as well
|
||||||
case /.*-(.*)\/(.*)@(.*)/.test(extension):
|
case /.*-(.*)\/(.*)@(.*)/.test(extension):
|
||||||
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
|
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
|
||||||
if (matches == null) {
|
|
||||||
// Shouldn't happen
|
|
||||||
add_script += await utils.getUnsupportedLog(
|
|
||||||
extension,
|
|
||||||
version,
|
|
||||||
'darwin'
|
|
||||||
);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
add_script += await utils.joins(
|
add_script += await utils.joins(
|
||||||
'\nadd_extension_from_github',
|
'\nadd_extension_from_github',
|
||||||
ext_name,
|
ext_name,
|
||||||
@ -294,15 +285,6 @@ export async function addExtensionLinux(
|
|||||||
// the version may match that as well
|
// the version may match that as well
|
||||||
case /.*-(.*)\/(.*)@(.*)/.test(extension):
|
case /.*-(.*)\/(.*)@(.*)/.test(extension):
|
||||||
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
|
matches = /.*-(.*)\/(.*)@(.*)/.exec(extension) as RegExpExecArray;
|
||||||
if (matches == null) {
|
|
||||||
// Shouldn't happen
|
|
||||||
add_script += await utils.getUnsupportedLog(
|
|
||||||
extension,
|
|
||||||
version,
|
|
||||||
'linux'
|
|
||||||
);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
add_script += await utils.joins(
|
add_script += await utils.joins(
|
||||||
'\nadd_extension_from_github',
|
'\nadd_extension_from_github',
|
||||||
ext_name,
|
ext_name,
|
||||||
|
Loading…
Reference in New Issue
Block a user