mirror of
https://github.com/shivammathur/setup-php.git
synced 2025-09-09 14:24:06 +07:00
Address code review feedback
This commit is contained in:

committed by
Shivam Mathur

parent
f42065d568
commit
26791e8412
@ -267,4 +267,22 @@ add_composertool() {
|
||||
# Function to get PHP version in semver format.
|
||||
php_semver() {
|
||||
php"$version" -v | grep -Eo -m 1 "[0-9]+\.[0-9]+\.[0-9]+" | head -n 1
|
||||
}
|
||||
}
|
||||
|
||||
# Function to install extension from a GitHub repository
|
||||
add_extension_from_github() {
|
||||
extension=$1
|
||||
org=$2
|
||||
repo=$3
|
||||
release=$4
|
||||
prefix=$5
|
||||
(
|
||||
add_devtools phpize
|
||||
delete_extension "$extension"
|
||||
git clone --recurse-submodules -b "$release" https://github.com/"$org"/"$repo" /tmp/"$repo-$release" || exit 1
|
||||
cd /tmp/"$repo-$release" || exit 1
|
||||
phpize && ./configure && make -j"$(nproc)" && sudo make install
|
||||
enable_extension "$extension" "$prefix"
|
||||
) >/dev/null 2>&1
|
||||
add_extension_log "$extension-$org/$repo@$release" "Installed and enabled"
|
||||
}
|
||||
|
@ -39,24 +39,6 @@ add_pecl_extension() {
|
||||
fi
|
||||
}
|
||||
|
||||
# Function to install extension from a GitHub repository
|
||||
add_extension_from_github() {
|
||||
extension=$1
|
||||
org=$2
|
||||
repo=$3
|
||||
release=$4
|
||||
prefix=$5
|
||||
(
|
||||
add_devtools phpize
|
||||
delete_extension "$extension"
|
||||
git clone --recurse-submodules -b "$release" https://github.com/"$org"/"$repo" /tmp/"$repo-$release" || exit 1
|
||||
cd /tmp/"$repo-$release" || exit 1
|
||||
phpize && ./configure && make -j"$(nproc)" && sudo make install
|
||||
enable_extension "$extension" "$prefix"
|
||||
) >/dev/null 2>&1
|
||||
add_extension_log "$extension-$org/$repo@$release" "Installed and enabled"
|
||||
}
|
||||
|
||||
# Function to fetch a brew tap
|
||||
fetch_brew_tap() {
|
||||
tap=$1
|
||||
|
@ -148,24 +148,6 @@ add_pecl_extension() {
|
||||
fi
|
||||
}
|
||||
|
||||
# Function to install extension from a GitHub repository
|
||||
add_extension_from_github() {
|
||||
extension=$1
|
||||
org=$2
|
||||
repo=$3
|
||||
release=$4
|
||||
prefix=$5
|
||||
(
|
||||
add_devtools phpize
|
||||
delete_extension "$extension"
|
||||
git clone --recurse-submodules -b "$release" https://github.com/"$org"/"$repo" /tmp/"$repo-$release" || exit 1
|
||||
cd /tmp/"$repo-$release" || exit 1
|
||||
phpize && ./configure && make -j"$(nproc)" && sudo make install
|
||||
enable_extension "$extension" "$prefix"
|
||||
) >/dev/null 2>&1
|
||||
add_extension_log "$extension-$org/$repo@$release" "Installed and enabled"
|
||||
}
|
||||
|
||||
# Function to setup phpize and php-config.
|
||||
add_devtools() {
|
||||
tool=$1
|
||||
|
Reference in New Issue
Block a user