Bump tough-cookie, jest and ts-jest

Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependencies [tough-cookie](https://github.com/salesforce/tough-cookie), [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [ts-jest](https://github.com/kulshekhar/ts-jest). These dependencies need to be updated together.


Removes `tough-cookie`

Updates `jest` from 24.9.0 to 29.6.1
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.6.1/packages/jest)

Updates `ts-jest` from 24.2.0 to 29.1.1
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/kulshekhar/ts-jest/compare/v24.2.0...v29.1.1)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: jest
  dependency-type: direct:development
- dependency-name: ts-jest
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/dependabot.yml

@@ -1,11 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: "github-actions"
-    directory: "/"
-    groups:
-      github-actions:
-        patterns: ["*"]
-    schedule:
-      interval: "weekly"
-    cooldown:
-      default-days: 7

.github/workflows/test.yml

@@ -4,76 +4,66 @@ on:
     branches:
       - dev
     paths-ignore:
-      - "*.md"
+      - '*.md'
   push:
     branches:
       - dev
     paths-ignore:
-      - "*.md"
+      - '*.md'
   workflow_dispatch:
+    branches:
+      - dev
+      - arm64
+      - master
+    paths-ignore:
+      - '*.md'
+  
 
 jobs:
   build:
-    strategy:
-      fail-fast: false
-      matrix:
-        runner:
-          - windows-latest
-          - windows-2025-vs2026
-    runs-on: ${{ matrix.runner }}
+    runs-on: windows-latest
     steps:
-      - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
+    - uses: actions/checkout@v2
 
-      - name: Setup MSBuild (vswhere-path)
-        id: setup_msbuild_explicit
-        uses: ./
-        with:
-          vswhere-path: C:\ProgramData\chocolatey\bin
+    - name: Setup MSBuild (vswhere-path)
+      id: setup_msbuild_explicit
+      uses: ./
+      with:
+        vswhere-path: C:\ProgramData\chocolatey\bin
 
-      - name: Setup MSBuild (PATH)
-        id: setup_msbuild_path
-        uses: ./
+    - name: Setup MSBuild (PATH)
+      id: setup_msbuild_path
+      uses: ./
 
-      - name: Setup MSBuild (fallback)
-        id: setup_msbuild_fallback
-        uses: ./
-        env:
-          PATH: ""
+    - name: Setup MSBuild (fallback)
+      id: setup_msbuild_fallback
+      uses: ./
+      env:
+        PATH: ''
 
-      - name: Setup MSBuild (x64)
-        if: runner.arch == 'X64'
-        id: setup_msbuild_path_x64
-        uses: ./
-        with:
-          vs-prerelease: true
-          msbuild-architecture: "x64"
+    - name: Setup MSBuild (x64)
+      if: always()
+      id: setup_msbuild_path_x64
+      uses: ./
+      with:
+        vs-prerelease: true
+        msbuild-architecture: 'x64'
 
-      - name: Setup MSBuild (arm64)
-        if: runner.arch == 'ARM64'
-        id: setup_msbuild_path_arm64
-        uses: ./
-        with:
-          vs-prerelease: true
-          msbuild-architecture: "arm64"
+    - name: Setup MSBuild (arm64)
+      if: always()
+      id: setup_msbuild_path_arm
+      uses: ./
+      with:
+        vs-prerelease: true
+        msbuild-architecture: 'arm64'
 
-      - name: Write MSBuild summary
-        if: always()
-        shell: pwsh
-        run: |
-          @"
-          ## MSBuild setup summary
+    - name: echo msbuild path
+      run: |
+        echo "vswhere-path: ${{ steps.setup_msbuild_explicit.outputs.msbuildPath }}"
+        echo "PATH: ${{ steps.setup_msbuild_path.outputs.msbuildPath }}"
+        echo "ARM PATH: ${{ steps.setup_msbuild_path_arm.outputs.msbuildPath }}"
+        echo "ARM PATH: ${{ steps.setup_msbuild_path_x64.outputs.msbuildPath }}"
+        echo "Fallback: ${{ steps.setup_msbuild_fallback.outputs.msbuildPath }}"
 
-          - Runner label: `${{ matrix.runner }}`
-          - Runner architecture: `${{ runner.arch }}`
-
-          | Probe | msbuildPath |
-          | --- | --- |
-          | vswhere-path | ${{ steps.setup_msbuild_explicit.outputs.msbuildPath || 'N/A' }} |
-          | PATH | ${{ steps.setup_msbuild_path.outputs.msbuildPath || 'N/A' }} |
-          | Fallback | ${{ steps.setup_msbuild_fallback.outputs.msbuildPath || 'N/A' }} |
-          | x64 | ${{ steps.setup_msbuild_path_x64.outputs.msbuildPath || 'N/A' }} |
-          | arm64 | ${{ steps.setup_msbuild_path_arm64.outputs.msbuildPath || 'N/A' }} |
-          "@ | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Encoding utf8 -Append
-
-      - name: echo MSBuild
-        run: msbuild -version
+    - name: echo MSBuild
+      run: msbuild -version

README.md

@@ -1,49 +1,27 @@
 # microsoft/setup-msbuild
-
 This action will help discover where the `MSBuild` tool is and automatically add it to the `PATH` environment variables for you so future steps in your Actions workflow can just initiate `msbuild` commands without knowing the full path.
 
-> [!IMPORTANT]
 > Please note this tool does NOT add other Visual Studio tools (like VSTest, cl, cmake, or others) to `PATH`
 
-## Breaking Changes in v4
-
-Starting with `v4`, the default value of `msbuild-architecture` is no longer always `x86`. When
-`msbuild-architecture` is not explicitly specified, the action now **auto-detects** the best
-architecture:
-
-- `x64` when running on a 64-bit machine **and** the resolved Visual Studio/MSBuild install is
-  version 17.0 or later (Visual Studio 2022+, which ships a native 64-bit MSBuild).
-- `x86` otherwise (older Visual Studio versions, or 32-bit hosts), matching the previous behavior.
-
-If you explicitly set `msbuild-architecture` (e.g. `x86`, `x64`, or `arm64`), that value is always
-respected and this auto-detection does not apply. If your workflow depends on always getting the
-32-bit MSBuild by default, set `msbuild-architecture: x86` explicitly.
-
 ## Example Usage
 
 ```yml
 - name: Add msbuild to PATH
-  uses: microsoft/setup-msbuild@v4
+  uses: microsoft/setup-msbuild@v1.1
 
 - name: Build app for release
   run: msbuild src\YourProjectFile.csproj -t:rebuild -verbosity:diag -property:Configuration=Release
 ```
 
-## Runners and included software
-
-This action is intended to be used within the GitHub Actions workflows using the model of 'runners' either hosted (provided by GitHub) or self-hosted (provided by you). The version and parameters you specify below are going to be scoped to what software actually exists on the runner image being used. For example, hosted runner images from GitHub typically do NOT have pre-release versions of Visual Studio on them so using `vs-prerelease` parameter noted below may not have intended effect when using hosted runners. The software included for GitHub-hosted runner images can always be found here: <https://github.com/actions/runner-images> which also includes information on when/how software on hosted images gets updated.
-
 ## Optional Parameters
-
 There are a few additional parameters that can be set if you need them. These are optional and should only be set if you know that you need them or what you are doing.
 
 ### Specifying specific versions of Visual Studio (optional)
-
 You may have a situation where your Actions runner has multiple versions of Visual Studio and you need to find a specific version of the tool.  Simply add the `vs-version` input to specify the range of versions to find.  If looking for a specific version, specify the minimum and maximum versions as shown in the example below, which will look for just 16.4.
 
 ```yml
 - name: Add msbuild to PATH
-  uses: microsoft/setup-msbuild@v4
+  uses: microsoft/setup-msbuild@v1.1
   with:
     vs-version: '[16.4,16.5)'
 ```
@@ -51,48 +29,39 @@ You may have a situation where your Actions runner has multiple versions of Visu
 The syntax is the same used for Visual Studio extensions, where square brackets like "[" mean inclusive, and parenthesis like "(" mean exclusive. A comma is always required, but eliding the minimum version looks for all older versions and eliding the maximum version looks for all newer versions. See the [vswhere wiki](https://github.com/microsoft/vswhere/wiki) for more details.
 
 ### Use pre-release versions of Visual Studio (optional)
-
 If you need your Actions runner to target a pre-release version of Visual Studio, simply add the `vs-prerelease` input.  This is necessary if you want to run an action on a virtual environment that contains a pre-release version of Visual Studio or self-hosted images that you may have that also have pre-release versions of Visual Studio installed.
 
 ```yml
 - name: Add msbuild to PATH
-  uses: microsoft/setup-msbuild@v4
+  uses: microsoft/setup-msbuild@v1.1
   with:
     vs-prerelease: true
 ```
 
 ### Specifying MSBuild architecture (optional)
-
-By default (as of `v4`), the action auto-detects the preferred MSBuild architecture: it uses `x64`
-when running on a 64-bit machine with Visual Studio/MSBuild 17.0 or later installed, and falls back
-to `x86` otherwise. You can override this by explicitly setting the `msbuild-architecture` input.
-Valid input values are `x86`, `x64`, and `arm64`. Note that the success of these will rely on the
-runner OS.
+By default the action will use the x86 architecture for MSBuild, but it is possible to target the x64 versions instead. Simply add the `msbuild-architecture` input. Valid input values are `x86` (default), `x64`, and `arm64`. Note that the success of these will rely on the runner OS.
 
 ```yml
 - name: Add msbuild to PATH
-  uses: microsoft/setup-msbuild@v4
+  uses: microsoft/setup-msbuild@v1.1
   with:
     msbuild-architecture: x64
 ```
 
 ## How does this work?
-
 This makes use of the vswhere tool which is a tool delivered by Microsoft to help in identifying Visual Studio installs and various components.  This tool is installed on the hosted Windows runners for GitHub Actions.  If you are using a self-hosted runner, you either need to make sure vswhere.exe is in your agent's PATH or specify a full path to the location using:
 
 ```yml
 - name: Add msbuild to PATH
-  uses: microsoft/setup-msbuild@v4
+  uses: microsoft/setup-msbuild@v1.1
   with:
     vswhere-path: 'C:\path\to\your\tools\'
 ```
 
 ## Notes on arguments
-
 While the Action enables you to specify a `vswhere` path as well as a `vs-version`, these are more advanced options and when using GitHub-hosted runners you should not need these and is recommended you don't specify them as they are optional.  Using these require you to fully understand the runner environment, updates to the tools on the runner, and can cause failures if you are out of sync.  For GitHub-hosted runners, omitting these arguments is the preferred usage.
 
 ## Building this repo
-
 As with most GitHub Actions, this requires NodeJS development tools.  After installing NodeJS, you can build this by executing:
 
 ```bash
@@ -104,14 +73,13 @@ npm run pack
 which will modify/create the /dist folder with the final index.js output
 
 # Credits
-
 Thank you to [Warren Buckley](https://github.com/warrenbuckley) for being a core contributor to this Action for the benefit of all developers!
 
 # Contributing
 
 This project welcomes contributions and suggestions.  Most contributions require you to agree to a
 Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us
-the rights to use your contribution. For details, visit <https://cla.opensource.microsoft.com>.
+the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.
 
 When you submit a pull request, a CLA bot will automatically determine whether you need to provide
 a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions

__tests__/main.test.ts

@@ -1,54 +0,0 @@
-import {
-  MIN_VS_VERSION_FOR_X64,
-  parseMajorVersion,
-  resolveMSBuildArchitecture
-} from '../src/main'
-
-describe('parseMajorVersion', () => {
-  it('parses a standard installationVersion string', () => {
-    expect(parseMajorVersion('17.9.34728.123')).toBe(17)
-  })
-
-  it('parses a single-segment version', () => {
-    expect(parseMajorVersion('16')).toBe(16)
-  })
-
-  it('trims whitespace before parsing', () => {
-    expect(parseMajorVersion('  17.0.0.0  ')).toBe(17)
-  })
-
-  it('returns undefined for an empty string', () => {
-    expect(parseMajorVersion('')).toBeUndefined()
-  })
-
-  it('returns undefined for a non-numeric string', () => {
-    expect(parseMajorVersion('not-a-version')).toBeUndefined()
-  })
-})
-
-describe('resolveMSBuildArchitecture', () => {
-  it('always respects an explicit architecture, regardless of OS/version', () => {
-    expect(resolveMSBuildArchitecture('x86', true, 17)).toBe('x86')
-    expect(resolveMSBuildArchitecture('x64', false, 15)).toBe('x64')
-    expect(resolveMSBuildArchitecture('arm64', true, 17)).toBe('arm64')
-  })
-
-  it('defaults to x64 on a 64-bit host with VS/MSBuild 17+', () => {
-    expect(resolveMSBuildArchitecture('', true, MIN_VS_VERSION_FOR_X64)).toBe(
-      'x64'
-    )
-    expect(resolveMSBuildArchitecture('', true, 18)).toBe('x64')
-  })
-
-  it('defaults to x86 on a 64-bit host with VS/MSBuild older than 17', () => {
-    expect(resolveMSBuildArchitecture('', true, 16)).toBe('x86')
-  })
-
-  it('defaults to x86 on a non-64-bit host even with VS/MSBuild 17+', () => {
-    expect(resolveMSBuildArchitecture('', false, 17)).toBe('x86')
-  })
-
-  it('defaults to x86 when the VS/MSBuild version could not be determined', () => {
-    expect(resolveMSBuildArchitecture('', true, undefined)).toBe('x86')
-  })
-})

action.yml

@@ -1,26 +1,27 @@
-name: "setup-msbuild"
-description: "Helps set up MSBuild into PATH for later usage."
-author: "Microsoft"
+name: 'setup-msbuild'
+description: 'Helps set up MSBuild into PATH for later usage.'
+author: 'Microsoft'
 branding:
   color: purple
   icon: terminal
 inputs:
   vswhere-path:
     required: false
-    description: "Folder location of where vswhere.exe is located if a self-hosted agent"
+    description: 'Folder location of where vswhere.exe is located if a self-hosted agent'
   vs-version:
-    description: "Version of Visual Studio to search; defaults to latest if not specified"
+    description: 'Version of Visual Studio to search; defaults to latest if not specified'
     required: false
   vs-prerelease:
-    description: "Enable searching for pre-release versions of Visual Studio/MSBuild"
+    description: 'Enable searching for pre-release versions of Visual Studio/MSBuild'
     required: false
   msbuild-architecture:
-    description: 'The preferred processor architecture of MSBuild. Can be either "x86", "x64", or "arm64". "x64" is only available from Visual Studio version 17.0 and later. If left unspecified, the action auto-detects the best option: "x64" on 64-bit machines when a Visual Studio/MSBuild 17.0+ install is found, otherwise "x86".'
+    description: 'The preferred processor architecture of MSBuild. Can be either "x86", "x64", or "arm64". "x64" is only available from Visual Studio version 17.0 and later.'
     required: false
+    default: 'x86'
 outputs:
   msbuildPath:
-    description: "The resulting location of msbuild for your inputs"
+    description: 'The resulting location of msbuild for your inputs'
 
 runs:
-  using: "node24"
-  main: "dist/index.js"
+  using: 'node16'
+  main: 'dist/index.js'

package.json

@@ -1,6 +1,6 @@
 {
   "name": "setup-msbuild",
-  "version": "4.0.0",
+  "version": "1.3.1",
   "private": true,
   "description": "Helps set up specific MSBuild tool into PATH for later usage.",
   "main": "lib/main.js",
@@ -9,7 +9,7 @@
     "format": "prettier --write **/*.ts",
     "format-check": "prettier --check **/*.ts",
     "lint": "eslint src/**/*.ts",
-    "pack": "ncc build lib/main.js -o dist",
+    "pack": "ncc build",
     "test": "jest",
     "all": "npm run build && npm run format && npm run lint && npm run pack"
   },
@@ -36,15 +36,15 @@
     "@types/jest": "^24.0.23",
     "@types/node": "^12.12.25",
     "@typescript-eslint/parser": "^2.8.0",
-    "@vercel/ncc": "^0.38.4",
+    "@zeit/ncc": "^0.20.5",
     "eslint": "^5.16.0",
     "eslint-plugin-github": "^2.0.0",
     "eslint-plugin-jest": "^22.21.0",
-    "jest": "^24.9.0",
+    "jest": "^29.6.1",
     "jest-circus": "^24.9.0",
     "js-yaml": "^3.13.1",
     "prettier": "^1.19.1",
-    "ts-jest": "^24.2.0",
+    "ts-jest": "^29.1.1",
     "typescript": "^3.6.4"
   }
-}
+}

src/main.ts

@@ -1,7 +1,6 @@
 import * as core from '@actions/core'
 import * as exec from '@actions/exec'
 import * as fs from 'fs'
-import * as os from 'os'
 import * as path from 'path'
 import * as io from '@actions/io'
 import {ExecOptions} from '@actions/exec/lib/interfaces'
@@ -10,56 +9,13 @@ const IS_WINDOWS = process.platform === 'win32'
 const VS_VERSION = core.getInput('vs-version') || 'latest'
 const VSWHERE_PATH = core.getInput('vswhere-path')
 const ALLOW_PRERELEASE = core.getInput('vs-prerelease') || 'false'
-const MSBUILD_ARCH_INPUT = core.getInput('msbuild-architecture')
-let MSBUILD_ARCH = MSBUILD_ARCH_INPUT
-
-// The minimum Visual Studio/MSBuild major version that ships a native x64 MSBuild.exe
-export const MIN_VS_VERSION_FOR_X64 = 17
-
-// Determines the effective MSBuild architecture to use.
-// If the user explicitly specified `msbuild-architecture`, that choice is always respected.
-// Otherwise (breaking change as of v4), the action auto-detects and prefers x64 when
-// running on a 64-bit OS and the resolved VS/MSBuild installation is version 17.0 or later.
-// If the VS version can't be determined, or the host isn't 64-bit, it falls back to x86.
-export function resolveMSBuildArchitecture(
-  explicitArch: string,
-  isWindows64Bit: boolean,
-  vsMajorVersion: number | undefined
-): string {
-  if (explicitArch) {
-    return explicitArch
-  }
-
-  if (
-    isWindows64Bit &&
-    vsMajorVersion !== undefined &&
-    vsMajorVersion >= MIN_VS_VERSION_FOR_X64
-  ) {
-    return 'x64'
-  }
-
-  return 'x86'
-}
-
-// Parses the major version number out of a vswhere `installationVersion` string
-// such as "17.9.34728.123". Returns undefined if it cannot be parsed.
-export function parseMajorVersion(
-  installationVersion: string
-): number | undefined {
-  const match = installationVersion.trim().match(/^(\d+)/)
-  if (!match) {
-    return undefined
-  }
-  const major = parseInt(match[1], 10)
-  return isNaN(major) ? undefined : major
-}
+let MSBUILD_ARCH = core.getInput('msbuild-architecture') || 'x86'
 
 // if a specific version of VS is requested
-let VSWHERE_EXEC =
-  '-products * -requires Microsoft.Component.MSBuild -property installationPath -latest '
+let VSWHERE_EXEC = '-products * -requires Microsoft.Component.MSBuild -property installationPath -latest '
 if (ALLOW_PRERELEASE === 'true') {
-  VSWHERE_EXEC += ' -prerelease '
-}
+    VSWHERE_EXEC += ' -prerelease '
+ }
 
 if (VS_VERSION !== 'latest') {
   VSWHERE_EXEC += `-version "${VS_VERSION}" `
@@ -108,39 +64,6 @@ async function run(): Promise<void> {
 
     core.debug(`Full tool exe: ${vswhereToolExe}`)
 
-    // if the user did not explicitly specify an architecture, auto-detect the
-    // preferred architecture based on the host OS and the resolved VS/MSBuild version
-    if (!MSBUILD_ARCH_INPUT) {
-      let vsMajorVersion: number | undefined
-      const versionOptions: ExecOptions = {}
-      versionOptions.listeners = {
-        stdout: (data: Buffer) => {
-          const installationVersion = data.toString().trim()
-          core.debug(`Found installation version: ${installationVersion}`)
-          const parsed = parseMajorVersion(installationVersion)
-          if (parsed !== undefined) {
-            vsMajorVersion = parsed
-          }
-        }
-      }
-
-      const versionExec = VSWHERE_EXEC.replace(
-        '-property installationPath',
-        '-property installationVersion'
-      )
-      await exec.exec(`"${vswhereToolExe}" ${versionExec}`, [], versionOptions)
-
-      const isWindows64Bit = os.arch() === 'x64' || os.arch() === 'arm64'
-      MSBUILD_ARCH = resolveMSBuildArchitecture(
-        MSBUILD_ARCH_INPUT,
-        isWindows64Bit,
-        vsMajorVersion
-      )
-      core.info(
-        `Auto-detected msbuild-architecture: ${MSBUILD_ARCH} (os.arch=${os.arch()}, vsMajorVersion=${vsMajorVersion})`
-      )
-    }
-
     let foundToolPath = ''
     const options: ExecOptions = {}
     options.listeners = {
@@ -195,24 +118,6 @@ async function run(): Promise<void> {
       return
     }
 
-    core.info(`Found MSBuild tool path: ${foundToolPath}`)
-    core.info(`Using MSBuild architecture: ${MSBUILD_ARCH}`)
-
-    // try to get the MSBuild version for diagnostic purposes; a failure here shouldn't fail the action
-    try {
-      let msbuildVersion = ''
-      const versionOptions: ExecOptions = {}
-      versionOptions.listeners = {
-        stdout: (data: Buffer) => {
-          msbuildVersion += data.toString()
-        }
-      }
-      await exec.exec(`"${foundToolPath}" -version -nologo`, [], versionOptions)
-      core.info(`Found MSBuild version: ${msbuildVersion.trim()}`)
-    } catch (error) {
-      core.debug(`Unable to determine MSBuild version: ${error.message}`)
-    }
-
     // extract the folder location for the tool
     const toolFolderPath = path.dirname(foundToolPath)
 
@@ -221,7 +126,7 @@ async function run(): Promise<void> {
 
     // add tool path to PATH
     core.addPath(toolFolderPath)
-    core.info(`Tool path added to PATH: ${toolFolderPath}`)
+    core.debug(`Tool path added to PATH: ${toolFolderPath}`)
   } catch (error) {
     core.setFailed(error.message)
   }