From 9c9a1a34a4c6a9f36400e23e479b9c33ec98a4bb Mon Sep 17 00:00:00 2001 From: Tim Heuer Date: Thu, 26 Mar 2020 08:42:27 -0700 Subject: [PATCH] Adding remark about arguments in readme --- .github/workflows/test.yml | 2 +- README.md | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6782fdb..62ea358 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,7 +16,7 @@ jobs: id: setup_msbuild uses: ./ with: - vs-version: "[16.4,16.5]" + vs-version: "[16.4,16.6]" - name: echo msbuild path run: echo "${{ steps.setup_msbuild.outputs.msbuildPath }}" diff --git a/README.md b/README.md index 808fdd7..14b3c41 100644 --- a/README.md +++ b/README.md @@ -28,6 +28,9 @@ This makes use of the vswhere tool which is a tool is delivered by Microsoft to vswhere-path: 'C:\path\to\your\tools\' ``` +## Notes on arguments +While the Action enables you to specify a `vswhere` path as well as a `vs-version`, these are more advanced options and when using GitHub-hosted runners you should not need these and is recommended you don't specify them. Using these require you to fully understand the runner environment, updates to the tools on the runner, and can cause failures if you are out of sync. For GitHub-hosted runners, omitting these arguments is the preferred usage. + ## Building this repo As with most GitHub Actions, this requires NodeJS development tools. After installing NodeJS, you can build this by executing: