actions/setup-dotnet
1
0
Fork 0
mirror of https://github.com/actions/setup-dotnet.git synced 2025-09-03 11:24:08 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix review points

Browse Source
This commit is contained in:
IvanZosimov
2023-04-13 10:33:52 +02:00
parent 7358a44590
commit 559e47b01b
3 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/installer.ts
View File

@ -17,6 +17,11 @@ export interface DotnetVersion {
qualityFlag: boolean;
}
enum DotnetInstallerLimits {
QualityInputMinimalMajorTag = 6,
LatestPatchSyntaxMinimalMajorTag = 5
}
export class DotnetVersionResolver {
private inputVersion: string;
private resolvedArgument: DotnetVersion;
@ -47,7 +52,11 @@ export class DotnetVersionResolver {
const majorTag = this.inputVersion.match(
/^(?<majorTag>\d+)\.\d+\.\d{1}x{2}$/
)?.groups?.majorTag;
if (majorTag && parseInt(majorTag) < 5) {
if (
majorTag &&
parseInt(majorTag) <
DotnetInstallerLimits.LatestPatchSyntaxMinimalMajorTag
) {
throw new Error(
`'dotnet-version' was supplied in invalid format: ${this.inputVersion}! The A.B.Cxx syntax is available since the .NET 5.0 release.`
);
@ -70,10 +79,13 @@ export class DotnetVersionResolver {
} else if (this.isNumericTag(major)) {
this.resolvedArgument.value = await this.getLatestByMajorTag(major);
} else {
// Resolve LTS version of .NET if "dotnet-version" is specified as *, x or X
// If "dotnet-version" is specified as *, x or X resolve latest version of .NET explicitly from LTS channel. The version argument will be set to "latest" by default.
this.resolvedArgument.value = 'LTS';
}
this.resolvedArgument.qualityFlag = parseInt(major) >= 6 ? true : false;
this.resolvedArgument.qualityFlag =
parseInt(major) >= DotnetInstallerLimits.QualityInputMinimalMajorTag
? true
: false;
}
public async createDotNetVersion(): Promise<DotnetVersion> {