Merge branch 'main' into refactor-nuget-cfg-parse

src/installer.ts

@@ -6,8 +6,9 @@ import * as hc from '@actions/http-client';
 import {chmodSync} from 'fs';
 import {readdir} from 'fs/promises';
 import path from 'path';
+import os from 'os';
 import semver from 'semver';
-import {IS_LINUX, IS_WINDOWS, IS_MAC} from './utils';
+import {IS_LINUX, IS_WINDOWS} from './utils';
 import {QualityOptions} from './setup-dotnet';
 
 export interface DotnetVersion {
@@ -112,40 +113,29 @@ export class DotnetVersionResolver {
 export class DotnetCoreInstaller {
   private version: string;
   private quality: QualityOptions;
-  private static readonly installationDirectoryWindows = path.join(
-    process.env['PROGRAMFILES'] + '',
-    'dotnet'
-  );
-  private static readonly installationDirectoryLinux = '/usr/share/dotnet';
-  private static readonly installationDirectoryMac = path.join(
-    process.env['HOME'] + '',
-    '.dotnet'
-  );
 
-  static addToPath() {
-    if (process.env['DOTNET_INSTALL_DIR']) {
-      core.addPath(process.env['DOTNET_INSTALL_DIR']);
-      core.exportVariable('DOTNET_ROOT', process.env['DOTNET_INSTALL_DIR']);
+  static {
+    const installationDirectoryWindows = path.join(
+      process.env['PROGRAMFILES'] + '',
+      'dotnet'
+    );
+    const installationDirectoryLinux = '/usr/share/dotnet';
+    const installationDirectoryMac = path.join(
+      process.env['HOME'] + '',
+      '.dotnet'
+    );
+    const dotnetInstallDir: string | undefined =
+      process.env['DOTNET_INSTALL_DIR'];
+    if (dotnetInstallDir) {
+      process.env['DOTNET_INSTALL_DIR'] =
+        this.convertInstallPathToAbsolute(dotnetInstallDir);
     } else {
       if (IS_WINDOWS) {
-        core.addPath(DotnetCoreInstaller.installationDirectoryWindows);
-        core.exportVariable(
-          'DOTNET_ROOT',
-          DotnetCoreInstaller.installationDirectoryWindows
-        );
-      } else if (IS_LINUX) {
-        core.addPath(DotnetCoreInstaller.installationDirectoryLinux);
-        core.exportVariable(
-          'DOTNET_ROOT',
-          DotnetCoreInstaller.installationDirectoryLinux
-        );
+        process.env['DOTNET_INSTALL_DIR'] = installationDirectoryWindows;
       } else {
-        // This is the default set in install-dotnet.sh
-        core.addPath(DotnetCoreInstaller.installationDirectoryMac);
-        core.exportVariable(
-          'DOTNET_ROOT',
-          DotnetCoreInstaller.installationDirectoryMac
-        );
+        process.env['DOTNET_INSTALL_DIR'] = IS_LINUX
+          ? installationDirectoryLinux
+          : installationDirectoryMac;
       }
     }
   }
@@ -155,6 +145,23 @@ export class DotnetCoreInstaller {
     this.quality = quality;
   }
 
+  private static convertInstallPathToAbsolute(installDir: string): string {
+    let transformedPath;
+    if (path.isAbsolute(installDir)) {
+      transformedPath = installDir;
+    } else {
+      transformedPath = installDir.startsWith('~')
+        ? path.join(os.homedir(), installDir.slice(1))
+        : (transformedPath = path.join(process.cwd(), installDir));
+    }
+    return path.normalize(transformedPath);
+  }
+
+  static addToPath() {
+    core.addPath(process.env['DOTNET_INSTALL_DIR']!);
+    core.exportVariable('DOTNET_ROOT', process.env['DOTNET_INSTALL_DIR']);
+  }
+
   private setQuality(
     dotnetVersion: DotnetVersion,
     scriptArguments: string[]
@@ -208,11 +215,6 @@ export class DotnetCoreInstaller {
         scriptArguments.push(`-ProxyBypassList ${process.env['no_proxy']}`);
       }
 
-      scriptArguments.push(
-        '-InstallDir',
-        `'${DotnetCoreInstaller.installationDirectoryWindows}'`
-      );
-      // process.env must be explicitly passed in for DOTNET_INSTALL_DIR to be used
       scriptPath =
         (await io.which('pwsh', false)) || (await io.which('powershell', true));
       scriptArguments = windowsDefaultOptions.concat(scriptArguments);
@@ -228,40 +230,26 @@ export class DotnetCoreInstaller {
       if (this.quality) {
         this.setQuality(dotnetVersion, scriptArguments);
       }
-
-      if (IS_LINUX) {
-        scriptArguments.push(
-          '--install-dir',
-          DotnetCoreInstaller.installationDirectoryLinux
-        );
-      }
-
-      if (IS_MAC) {
-        scriptArguments.push(
-          '--install-dir',
-          DotnetCoreInstaller.installationDirectoryMac
-        );
-      }
     }
+    // process.env must be explicitly passed in for DOTNET_INSTALL_DIR to be used
+    const getExecOutputOptions = {
+      ignoreReturnCode: true,
+      env: process.env as {string: string}
+    };
     const {exitCode, stdout} = await exec.getExecOutput(
       `"${scriptPath}"`,
       scriptArguments,
-      {ignoreReturnCode: true}
+      getExecOutputOptions
     );
     if (exitCode) {
       throw new Error(`Failed to install dotnet ${exitCode}. ${stdout}`);
     }
 
-    return this.outputDotnetVersion(
-      dotnetVersion.value,
-      scriptArguments[scriptArguments.length - 1]
-    );
+    return this.outputDotnetVersion(dotnetVersion.value);
   }
 
-  private async outputDotnetVersion(
-    version,
-    installationPath
-  ): Promise<string> {
+  private async outputDotnetVersion(version): Promise<string> {
+    const installationPath = process.env['DOTNET_INSTALL_DIR']!;
     let versionsOnRunner: string[] = await readdir(
       path.join(installationPath.replace(/'/g, ''), 'sdk')
     );

src/utils.ts

@@ -1,3 +1,2 @@
 export const IS_WINDOWS = process.platform === 'win32';
 export const IS_LINUX = process.platform === 'linux';
-export const IS_MAC = process.platform === 'darwin';