actions/cache
1
0
Fork 0
mirror of https://github.com/actions/cache.git synced 2024-12-26 19:43:04 +07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #942 from actions/vsvipul/fix-sort

Browse Source 
Remove sort logic from inputs
This commit is contained in:
Vipul 2022-10-03 13:29:55 +05:30 committed by GitHub
commit edc49897ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
__tests__/actionUtils.test.ts
View File

@ -215,23 +215,6 @@ test("getInputAsArray handles empty lines correctly", () => {
expect(actionUtils.getInputAsArray("foo")).toEqual(["bar", "baz"]); expect(actionUtils.getInputAsArray("foo")).toEqual(["bar", "baz"]);
}); });
test("getInputAsArray sorts files correctly", () => {
testUtils.setInput(
"foo",
"bar\n!baz\nwaldo\nqux\nquux\ncorge\ngrault\ngarply"
);
expect(actionUtils.getInputAsArray("foo")).toEqual([
"!baz",
"bar",
"corge",
"garply",
"grault",
"quux",
"qux",
"waldo"
]);
});
test("getInputAsArray removes spaces after ! at the beginning", () => { test("getInputAsArray removes spaces after ! at the beginning", () => {
testUtils.setInput( testUtils.setInput(
"foo", "foo",
@ -240,11 +223,11 @@ test("getInputAsArray removes spaces after ! at the beginning", () => {
expect(actionUtils.getInputAsArray("foo")).toEqual([ expect(actionUtils.getInputAsArray("foo")).toEqual([
"!bar", "!bar",
"!baz", "!baz",
"!quux",
"!qux", "!qux",
"!waldo", "!quux",
"corge", "corge",
"grault! garply" "grault! garply",
"!waldo"
]); ]);
}); });

2
__tests__/restore.test.ts
View File

@ -147,7 +147,7 @@ test("restore with no key", async () => {
test("restore with too many keys should fail", async () => { test("restore with too many keys should fail", async () => {
const path = "node_modules"; const path = "node_modules";
const key = "node-test"; const key = "node-test";
const restoreKeys = [...Array(20).keys()].map(x => x.toString()).sort(); const restoreKeys = [...Array(20).keys()].map(x => x.toString());
testUtils.setInputs({ testUtils.setInputs({
path: path, path: path,
key, key,

3
dist/restore/index.js vendored
View File

@ -38437,8 +38437,7 @@ function getInputAsArray(name, options) {
.getInput(name, options) .getInput(name, options)
.split("\n") .split("\n")
.map(s => s.replace(/^!\s+/, "!").trim()) .map(s => s.replace(/^!\s+/, "!").trim())
.filter(x => x !== "") .filter(x => x !== "");
.sort();
} }
exports.getInputAsArray = getInputAsArray; exports.getInputAsArray = getInputAsArray;
function getInputAsInt(name, options) { function getInputAsInt(name, options) {

3
dist/save/index.js vendored
View File

@ -38437,8 +38437,7 @@ function getInputAsArray(name, options) {
.getInput(name, options) .getInput(name, options)
.split("\n") .split("\n")
.map(s => s.replace(/^!\s+/, "!").trim()) .map(s => s.replace(/^!\s+/, "!").trim())
.filter(x => x !== "") .filter(x => x !== "");
.sort();
} }
exports.getInputAsArray = getInputAsArray; exports.getInputAsArray = getInputAsArray;
function getInputAsInt(name, options) { function getInputAsInt(name, options) {

3
src/utils/actionUtils.ts
View File

@ -62,8 +62,7 @@ export function getInputAsArray(
.getInput(name, options) .getInput(name, options)
.split("\n") .split("\n")
.map(s => s.replace(/^!\s+/, "!").trim()) .map(s => s.replace(/^!\s+/, "!").trim())
.filter(x => x !== "") .filter(x => x !== "");
.sort();
} }
export function getInputAsInt( export function getInputAsInt(